FIX: Compact path array to support multiple shallow path belongs_to #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollizeyen
changed the title
ollizeyen
changed the title
ollizeyen
changed the title
ollizeyen
force-pushed
the
belongs_to_fix
branch
from
de06ffb
to
3b799a3
Compare
|
Thanks for taking the time! can you please update the changelog? |
|
is there a test case that can be added? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compacts the the returned path array in
_prefix_pathto prevent URI from breaking in case of multiplebelongs_toassocs.Addresses #369
I'm not sure why travis is failing. Locally all tests are green.